Commit graph

876 commits

Author SHA1 Message Date
Malcolm Robb a296f2783f Make stats gathering conditional on Modes.stats
There is a quite complex if/else construct for gathering statistics
inside the main decodeModeS loop. To speed the loop up when not
gathering statistics, make the whole construct conditional on Modes.stat
being set.

Also tidy up a few comments
2013-04-30 10:46:23 +01:00
Malcolm Robb 2e21367f85 Calculate DF and size in decodeModeMessage
Allow the decodeModeMessage function to re-calculate msgtype and
msgbits. This makes the code a bit more portable by not requiring the
calling function to fill in these fields before the call.
2013-04-30 10:41:48 +01:00
Malcolm Robb c81498a0d0 Improve DF field error correction speed
Use bitmasks to speed up the detection of valid and invalid ICAO DF
field types.
2013-04-30 10:35:52 +01:00
Malcolm Robb 8d65abd317 Sanity Check on msglen after decoding
Add a sanity check to ensure that msglen is consistent with the DF type.
2013-04-30 10:32:23 +01:00
Malcolm Robb 5f7ed42050 VK1ET : Ctrl/C and other cleanup code
Changes supplied by John VK1ET.

This tidies up the thread termination, which then allows for use of [a
trapped] Ctrl/C to cleanly terminate the program and dump stats if flag
set.
2013-04-29 22:14:06 +01:00
Malcolm Robb 50cedd7fe2 Major re-write of decodeModesMessage
Lots of changes to the decodeModesMessages() function, and associated
helper functions, with the aim of speeding the code up by reducing the
number of calls to the CRC functions. Also, only update the mm variables
which are part of the message we're decoding.

Change the way CRC's are generated and checked.
Change the way single and double bit error is implemented.
General tidy up of the function to make it more readable.
2013-04-29 18:53:11 +01:00
Malcolm Robb e9b463d25c Update displayModesMessage()
Update displayModesMessage() to show additional ICAO defined DF types.
2013-04-29 18:39:40 +01:00
Malcolm Robb 19c11509e7 Mode S Gillham altitude changes
Modify all the Mode=S Gillham altitude decoding to use a new function
decodeGillhamField()

Change the Mode-S signal strength so that it rounds to the nearest
integer
2013-04-29 18:33:59 +01:00
Malcolm Robb e161b7662c DF Error detection and Correction
Added additional error detection and correction to the DF field of the
first byte in every ModeS frame.
2013-04-29 01:30:12 +01:00
Malcolm Robb 7cf79580a4 Change the message length decision
Assume that DF0-DF15 are all short 56 bit messages
Assume that DF16-DF31 are all long 112 bit messages

This helps us error detect and error recover for bits in the first byte
2013-04-28 20:53:30 +01:00
Malcolm Robb 748f2f5e91 Adjust --interactive display
Allow 8 character Longitudes to cope with -179.999

Change the type of signalLevel to unsigned chae. Negative signal levels
make no sense.
2013-04-28 16:24:33 +01:00
Malcolm Robb 8ed0574ac8 Implement 100 ft Altitudes
The DF's for altitude include a Q bit to distinguish either 100ft or
25ft altitude encoding. This version implements the 100ft increments
used by older aircraft. These codes are basically ModeC altitudes
transmitted over ModeS.
2013-04-28 02:17:57 +01:00
Malcolm Robb 05187f76e7 Add items to --interactive display
Reformat the --interactive display to show more information

Add a "Mode" column. This displays the The primary message type "S" or
"A" plus any matching modes "a" and/or "c". Requires --modeac switch.

Add a "Sig" column to show the signal strength.
2013-04-27 00:18:14 +01:00
Malcolm Robb 4d370bd247 Change default for error correction to OFF
Add a --fix command line switch to enable error correction using CRC.
Change the default to OFF/Disabled.

Error correction can very occasionally result in an incorrect solution
to the crc equation.  It also takes significant CPU work for very few
corrected results. Therefore, the default has been changed to OFF, but
you can re-enable it if you wish by using the --fix command line switch.
2013-04-26 10:12:47 +01:00
Malcolm Robb f77a85e8b8 VK1ET : Additions to check fflags
Implement changes suggested by John/VK1ET

Changes to cprNFunction to ensure fflag {was 'isodd'} is used as a flag.
Fix to decodeCPRrelative to pass 'surface' flag.
2013-04-26 09:49:53 +01:00
Malcolm Robb 2acb0947f0 Changes to Mode A/C/S matchup code
Try to improve the matching of ModeA/C codes to Known Mode-S
2013-04-26 01:40:52 +01:00
Malcolm Robb 25f92e54ba Change Squawk/ModeA code
The original code stores the squawk as a decimal (base 10) value. Change
this to a hex value to reduce the amount of maths required to convert
the input binary value..

Rename all the variables used to store the squawk to "modeA", rather
than variously identity, squawk and modeA.
2013-04-25 23:22:34 +01:00
Malcolm Robb f9c1dc1da5 Remove duplicate varbles
Several variables within structures contain the same information in
different forms.

The aircraft structure contains addr and hexaddr. Hexaddr is a printable
string version of addr. However, hexaddr is only ever used in printf
statments, so we can use printf(%06x) to print addr. This saves a printf
for every received command.

The modesMessage structure contains addr, and aa1,aa2,aa3 as separate
bytes. aa1,aa2 and aa3 are only ever used to construct addr, and to
print out. Therefore, we can use addr instead of them..
2013-04-25 21:17:00 +01:00
Malcolm Robb 3766492067 Change Mode-A/C to Mode-S detection
The original code made an attempt to reconcile a newly arrived ModeA/C
message with every known Mode-S report at the time of detection.
However, the results of matching up Modes A/C and S are only used in the
interactive display routine, and that is only called periodically from
within the BackgroundTasks loop.

Doing the matching on every ModeA/C arrival incurs quite a large CPU
processing load. Moving the matching up routine to the backgroundTasks
loop means that the task is performed muck less frequently and therefore
uses less CPU time.
2013-04-24 23:47:08 +01:00
Malcolm Robb 3dbc0efffc VK1ET : Decode mode ASCII hex input message types
Modifications entirely base on code supplied by John VK1ET.

Supports additional AVR raw ASCII input message stream types
2013-04-24 20:46:59 +01:00
Malcolm Robb a04e399d7e VK1ET : Implement Relative CPR decoding
Modifications entirely base on code supplied by John VK1ET.

Implements relative CPR Lat/Long decoding for --interactive display
2013-04-24 20:24:46 +01:00
Malcolm Robb b78b60677c Improvements to Mode A/C display
Allow a greater range and negative values for Mode C (down to -1200
feet)

Stop attempting to feed ModeA/C data to SBS Output stream.

Allow Mode A only matches to Mode-S squawks when the Mode A code does
not conflict with any possible (legal) Mode C code.

Allow Mode C matches to track aircraft climbing and descending
relatively slowly. This also helps when trying to match Mode-S altitudes
which are 25 foot increments, with Mode C altitudes which are in 100
foot increments.
2013-04-24 00:13:18 +01:00
Malcolm Robb d63ac81a6a Updated comments, ,no code changes 2013-04-23 22:18:15 +01:00
Malcolm Robb 9fff65ba58 Implement Mode A/C decoding
First attempt at decoding legacy SSR Modes A and C.

If the command line switch --modeac is used, the program will now
attempt to recover Mode A/C signals contained in the raw I/Q data
stream. The current recovery mechanism is quite strict and does not cope
well with overlapping and corrupt SSR replies. I estimate that less than
20% of possible returns are decoded correctly. Hopefully over the next
few iterations this can be improved.

If outputting raw data it is recommended to use the --net-ro-size and
--net-ro-rate command line options to reduce the number of very small
ethernet packets that will be generated by mode A/C replies.
2013-04-22 23:31:59 +01:00
Malcolm Robb 39cb96f24b Fix several bugs in input/output fromat
Thanks to vk1et for these.

1) Correct for additional timestamp langth in raw output buffer when
using mlat mode

2) Don't output a timestamp when the message has been received from a
remote site (the internet). This is to avoid upsetting MLAT because
there is an indeterminate delay between reception at the remote site and
subsequent message arrival in the local dump1090 instance.

3) Allow @ character for raw data input with timestamp, and correctly
calculate the length.
2013-04-20 11:29:27 +01:00
Malcolm Robb 11265089b4 Fix Bug in Beast Mode Output
Original code put the signal strength in before the timestamp. It should
be after.

Also add some code to support MODE A/C output at a future date.
2013-04-19 15:29:39 +01:00
Malcolm Robb e98728108c Bug fix in vertical sign
Incorrect shift amount when detecting vertical rate sign.  Thanks
John-vk1et.
2013-04-19 09:32:34 +01:00
Malcolm Robb 3d25f4bf1a Changes to prevent stale output in SBS-1 format
The original code calculates Lat/Long only if it receives two DF-17
(subtype 9 or 18) within one second of each other. I have no idea why.
It then caches the results in the aircrafts data structure for use in
the --interactive display.

When SBS-1 style ASCII output is selected (port 30003) the code does not
attempt to calculate Lat/Long from the data just received - instead it
picks it up from the cached information in the aircraft's data
structure.

However, if the data isn't being updated this results in stale Lat/Long
being sent out. This is most likely to occur when the aircraft is at the
extreme edge of the receivers range when it may be getting some DF-17s
containing Lat/Long, but not 2 per second. The program will continue
sending the stale data until the aircraft finally times out (default 60
seconds)

I have modified the code to include a sbsflags variable in the aircraft
data structure. When a new Lat/Long is decoded and put into the
structure, a bit is set to indicate SBS_LAT_LONG_FRESH. Then, once the
Lat/Long is output the first time, the bit is cleared. Thereafter the
code will not populate the Lat/Long fields in the output message until
SBS_LAT_LONG_FRESH is set again.
2013-04-17 23:09:01 +01:00
Malcolm Robb bbcf68cf11 Nunojpg Southern Hemisphere bug fix + 1
1) Incorporate nunojpg southern hemisphere bug fix
2) Initialise Modes.stat_DF_Corrected variable
2013-04-17 20:09:49 +01:00
Malcolm Robb a75442d11d Up issue the version and commit
Version 1.01.1503.13
2013-04-15 23:26:12 +01:00
Malcolm Robb 2431dc0c77 Added --net-ro-rate command line switch
The default is 0. This works in conjunction with --net-ro-size.

The program will attempt to gather up "net-ro-size" raw bytes before
sending them out over Ethernet. However, to avoid a long wait if the
traffic density is very low, the program will only wait for
"net-ro-rate" 64mS periods since the last send. before sending any data
added to the output buffer since the last send. This allows the user to
tailor the network load to suit their requirements.
2013-04-15 23:17:08 +01:00
Malcolm Robb 7779ef4d4f Correct CRLF order in SBS-1 ASCII output 2013-04-15 22:37:10 +01:00
Malcolm Robb b15ae2a544 Print DF-11 II/SI 2013-04-15 22:18:45 +01:00
Malcolm Robb 96afd52cb0 Speed up Squawk Decode
Re-write to avoid multiple reads of the same memory variable.
2013-04-15 22:12:40 +01:00
Malcolm Robb 6619d21970 Speed up Error Correction
Move memcopy to outside the main bit loop, and just flip the modified
bit back at the end of each loop if it didn;t work

Pass in a pointer to the mm structure being corrected, and fix-up the
crc with the value inside the function, rather than re-calculate on
return
2013-04-15 22:01:56 +01:00
Malcolm Robb bdf985a792 Don't attempt to error correct DF-11
Don't attempt to error correct DF-11, because we can't be sure that the
checksum/crc is supposed to be 0.

Also a few typo's corrected
2013-04-15 21:55:46 +01:00
Malcolm Robb bb20d0b5b8 SBS-1 ASCII output changes suggested by JungleJet
1) Populate Field 3 witn "111"
2) Populate field 4 with "11111"
3  Populate Field 6 with "111111"
4) End the record with <CRLF>, rather than just <LF>
5) Increase the ctrCommon buffer size to cope with additional field data

Apparently, this makes the output more compatible with Plane Plotter and
RTL1090.
2013-04-15 00:51:04 +01:00
Malcolm Robb 249c11a4c3 Add --net-ro-size command line switch
Allow the user to specify the minimum size of raw data to be sent to the
TCP port. Dump1090 will buffer up raw data until it has at least this
many bytes to send to the TCP socket.

The default is 0, which means every frame is sent to the TCP socket as
it is decoded. The maximum value is limited to 1300 bytes.

Note the buffer will  be flushed every 65 ms regardless of the amount of
data in it so that excessive in transmission do not occur.
2013-04-14 22:51:50 +01:00
Malcolm Robb 0263793928 Add version number to help output screen 2013-04-14 22:03:19 +01:00
Malcolm Robb 444b1cf3a2 Changed the date separator in SBS-1
Changed the separator from \ to /
2013-04-13 02:09:57 +01:00
Malcolm Robb 09d72d2897 Merge JungleJet Updates 2013-04-13 01:37:02 +01:00
Malcolm Robb d96f3a679e Added Raw Output Buffering
The original code wrote every individual received frame to the TCP port.
Some O/S's buffer smaller writes into larger packets. It appears that
some versions of Linux don't. The result is that the (Ethernet) network
gets bombarded with lots of small Ethernet packets.

Therefore, I've added a 1500 byte output buffer to the raw output
functions. Data is written into this buffer by the raw output routines.

Data is flushed out to the TCP port when either.
1) The latest write to the output buffer takes the contents to more than
1300 bytes
2) At the end of every processed block of data supplied by rtl-sdr. This
will be every 56mS or so,

The end result should be that on systems detecting a lot of traffic, you
should see lots of > 1300-byte Ethernet packets. On systems receiving
less traffic, you should see one network packet every 56 mS or so.

The total number of network packets should be much reduced, and their
average size much bigger. The worst case delay in transmission will be
56 mS.
2013-04-12 22:39:33 +01:00
Malcolm Robb 1324e28a38 Add Timestamps to SBS-1 format output
As requested by mlino

Note : I haven't been able to validate that the format is correct. I
think it should be Ok, but it needs someone with an SBS setup to check
it. Any offers?
2013-04-12 22:03:04 +01:00
Malcolm Robb 1175a03f4b Another attempt to remove UNIX compiler warnings
M$ VC 6.0 does not like long long
UNIX compilers don't like printing int64_t or uint64_t as %lld
Raspberry Pi Linux doesn;t like PRId64

So I give up.

I've changed the affected variables to bog standard unsigned ints.
Assuming these compile as 32 bit unsigned's, its unlikely youll have the
program running long enough for these to overflow.
2013-04-12 21:06:19 +01:00
Malcolm Robb 8c024d1736 Try to correct single bit errors in the DF field
If noist/sampling/Nyquist errors cause bit detection errors in the DF
pare of the frame, then we may not be able to work out the correct
length of the message. We have to guess whether the bit should be a 0 or
a 1.

In such circumstances we assume the message length is long(112 bits)
However, if we start to get encoding errors after bit 56 the we attempt
to change our original guess at the bit, and invert it. If this change
of guess would have resulted in a short message, and if the short
message would have been error free then we can recover.
2013-04-12 20:45:12 +01:00
junglejet 0c91c5f61f Merge pull request #1 from junglejet/Debug
Debug
2013-04-12 03:44:05 -07:00
junglejet 44ca030d3f committ repeated
committ repeated
2013-04-12 12:30:18 +02:00
junglejet c4956704e7 --mlat option and --interactive-rtl1090 option added
--mlat option introduced: to display raw data in Beast ascii format with
counter (@...;), does not affect Beast binary format ;
--interactive-rtl1090 option introduced: order of flight table Iin
interactive mode) and some formats adopted to RTL1090 format, so
comparison is easier
2013-04-12 12:15:52 +02:00
Malcolm Robb 63622355e3 Change the message bit decoder
Change (and hopefully improve) the Message bit decoder.

When decoding bits, a "0" is encoded as (m[j]<m[j+1]), and a "1" is
(m[j]>m[j+1]) . However, there is a problem if mpj[ == m[j+1] because we
can't decide what it's supposed to be.

Antirez's original code defaults to a '1', and then lets the bit error
detection code sort it out. I *think* it's better to default to '0'
because it's more likely that noise added to the signal will produce a
spurious '1' rathar than anything subtracting from the signal to produce
a spurious '0'

Also, Antirez''s code only looks for errors in the first bit of the
message. I don't know why  this is.

There is a potential problem in deciding the message length if there are
any errors in the first 5 bits decoded, because this defines the message
type (the DF-??), and it's the DF that determines how many bits the
message shall contain.

If there is an error in the first 5 bits, then we could ignore the DF,
and continue decoding a long format (112 bits). However, for weak
signals, if the message is a short one (56 bits) this results in the
sigStrength decaying to the point where it's level drops below squelch,
so we discard a possibly decodeable 56bit

However, if we assume it's a short message, and only decode 56 bits, and
it's really a long message we won't have decoded all the bits.

Not sure what to do about this
2013-04-12 10:53:46 +01:00
Malcolm Robb ff697dbb51 Improve the decoding for DF-11
Three changes in this one

1) Change the checksum testing for DF-11
2) Recode the Checksum generation routine to use pointers.
3) Tidy up the appearance of some print debug statments
2013-04-11 19:01:03 +01:00