Commit graph

1474 commits

Author SHA1 Message Date
Oliver Jowett 39aeb7a48c Remove comm-b "consistency" bonuses, look at inconsistent data only.
Rescale penalties so badly inconsistent messages will tend to get
the same penalty in all formats, so the ambiguity check kicks in.

With this final change the HEADING_SPEED and TRACK_TURN message rates
are almost identical, which is what we'd expect to see if the
interrogator is asking for both at about the same rate.

Before:

    567 AMBIGUOUS
   7445 GICB_CAPS
  19173 EMPTY_RESPONSE
  75252 UNKNOWN
  76469 AIRCRAFT_IDENT
 127603 ACAS_RA
 212654 HEADING_SPEED
 223068 DATALINK_CAPS
 229807 TRACK_TURN
 269267 VERTICAL_INTENT
    466 "suspicious"

After:

   7445 GICB_CAPS
  17432 AMBIGUOUS
  19173 EMPTY_RESPONSE
  75252 UNKNOWN
  76469 AIRCRAFT_IDENT
 127603 ACAS_RA
 212718 HEADING_SPEED
 212878 TRACK_TURN
 223068 DATALINK_CAPS
 269267 VERTICAL_INTENT
    328 "suspicious"
2019-05-02 18:19:27 +08:00
Oliver Jowett 5eb0bd10ea Bail out on unlikely comm-b data values in more places.
Before:

    575 AMBIGUOUS
   7090 GICB_CAPS
  19173 EMPTY_RESPONSE
  71686 UNKNOWN
  76469 AIRCRAFT_IDENT
 127603 ACAS_RA
 212887 HEADING_SPEED
 223068 DATALINK_CAPS
 230008 TRACK_TURN
 272746 VERTICAL_INTENT

    861 "suspicious"

After:

    567 AMBIGUOUS
   7445 GICB_CAPS
  19173 EMPTY_RESPONSE
  75252 UNKNOWN
  76469 AIRCRAFT_IDENT
 127603 ACAS_RA
 212654 HEADING_SPEED
 223068 DATALINK_CAPS
 229807 TRACK_TURN
 269267 VERTICAL_INTENT

    466 "suspicious"
2019-05-02 18:06:17 +08:00
Oliver Jowett f968fea390 Just bail out of comm-b decoding early on really bad data, don't bother with a big negative score.
No change to test results.
2019-05-02 18:03:40 +08:00
Oliver Jowett d5741bf8c8 Require more fields to be populated in BDS5,0/BDS6,0 before we'll accept them at all.
Before:

   7090 GICB_CAPS
  10667 AMBIGUOUS
  19173 EMPTY_RESPONSE
  62527 UNKNOWN
  76469 AIRCRAFT_IDENT
 127603 ACAS_RA
 210286 HEADING_SPEED
 223068 DATALINK_CAPS
 232824 TRACK_TURN
 271598 VERTICAL_INTENT

   2517 "suspicious"

After:

    575 AMBIGUOUS
   7090 GICB_CAPS
  19173 EMPTY_RESPONSE
  71686 UNKNOWN
  76469 AIRCRAFT_IDENT
 127603 ACAS_RA
 212887 HEADING_SPEED
 223068 DATALINK_CAPS
 230008 TRACK_TURN
 272746 VERTICAL_INTENT

    861 "suspicious"
2019-05-02 17:58:03 +08:00
Oliver Jowett c9bea6a21c Store comm-b gs in gs.selected to help the decoder tests out.
Usually this is set in track.c, but the tests don't use that code path.

This somewhat increases the number of "suspicious" messages found.
2019-05-02 17:54:48 +08:00
Oliver Jowett 27f41c178f Allow comm-b aircraft-ident messages containing @, but don't actually use the callsign.
before:
  62905 UNKNOWN
  76091 AIRCRAFT_IDENT

after:
  62527 UNKNOWN
  76469 AIRCRAFT_IDENT
2019-05-02 17:51:46 +08:00
Oliver Jowett b8fb5e5fe5 If there is no single best-scoring comm-b format, mark the message as ambiguous.
This mostly affects TRACK_TURN messages on my test set. before:

 127603 ACAS_RA
  19173 EMPTY_RESPONSE
 210286 HEADING_SPEED
 223068 DATALINK_CAPS
 243445 TRACK_TURN
 271644 VERTICAL_INTENT
  62905 UNKNOWN
   7090 GICB_CAPS
  76091 AIRCRAFT_IDENT

  15973 "suspicious"

after:

  10667 AMBIGUOUS
 127603 ACAS_RA
  19173 EMPTY_RESPONSE
 210286 HEADING_SPEED
 223068 DATALINK_CAPS
 232824 TRACK_TURN
 271598 VERTICAL_INTENT
  62905 UNKNOWN
   7090 GICB_CAPS
  76091 AIRCRAFT_IDENT

   2258 "suspicious"
2019-05-02 17:44:37 +08:00
Oliver Jowett 0306c7edfd Update .gitignore for new binaries 2019-05-02 17:31:08 +08:00
Oliver Jowett 564f033087 Add some oneoff tools for comm-b decoding testing 2019-05-02 17:29:46 +08:00
Oliver Jowett d33b1160f2 Add COMMB_AMBIGUOUS for Comm-B messages we're not sure of (not yet used) 2019-05-02 17:29:04 +08:00
Oliver Jowett 1b5b0dfa03 Put ais_charset in its own file to make building commb tests a little easier 2019-05-02 17:24:26 +08:00
Oliver Jowett 74d7ead41b Move convert_benchmark into oneoff/ 2019-05-02 17:21:56 +08:00
Oliver Jowett d575cc0d00 Fix the markup that got lost when merging da41d820f6 2019-04-29 21:31:18 +08:00
Oliver Jowett b84fffc443
Merge pull request #43 from jprochazka/build-instructions
jessie build instructions - suggest a particular libbladerf tag
2019-04-29 21:29:45 +08:00
Joe Prochazka f573b843c3
Merge branch 'dev' into build-instructions 2019-04-29 09:27:49 -04:00
Joe Prochazka da41d820f6
Proper libbladerf1 build instructions. 2019-04-29 09:10:34 -04:00
Oliver Jowett e419719731 Minimal polyfill to support building against both bladeRF1 & bladeRF2 libraries 2019-04-28 15:16:58 +08:00
Oliver Jowett 19f26968c7 Explicit instructions for stretch 2019-04-28 15:08:01 +08:00
Oliver Jowett 34bfe10317 Rework use of pkg-config to work around librtlsdr packaging bugs in ubuntu disco 2019-04-17 11:58:59 +08:00
Oliver Jowett f13f8dfce8 Fix prepare-build with DEBEMAIL et al containing spaces 2019-04-17 11:46:03 +08:00
Eric Tran 4d683ac50c Version bump to 3.7.1~dev 2019-04-15 11:26:51 -05:00
Oliver Jowett 0f23e514c6
Merge pull request #31 from mhamlet/patch-1
Fixing markup of code parts in README
2019-04-13 11:46:28 +08:00
Oliver Jowett a24718feca
Merge pull request #41 from henry1952/patch-3
Fix an error in the bit range used to decode CF in DF18 messages (harmless)
2019-04-13 11:38:48 +08:00
henry1952 37e49906d1
Update mode_s.c 2019-04-11 19:01:07 +02:00
Eric Tran d54c452683
Merge pull request #40 from wiedehopf/overflow_fix
Overflow fix
2019-04-09 08:52:11 -05:00
Matthias Wirth 82c5ff6724 Fix possible missing \n termination of TSV messages
If the \n termination of TSV messages is missing, faup1090 encounters
the following error:
Caught background error: list must have an even number of elements
    while executing
"array set row [split $line "\t"]"
    (object "::faup1090" method "::FaupConnection::data_available" body line 28)

This missing termination with \n can happen when p == end is true in the
overrun check. vsnprintf will always terminate the string with \0, so if
the vsnprintf is called to write the to the last position in the buffer
(end-1), it will write \0 instead to terminate the string as not to
overflow the buffer.
To catch that possibility the overrun check is changed to p < end as
then vsnprintf is assured to have had enough room to write the \0
termination to end-1.
2019-04-08 20:29:56 +02:00
Matthias Wirth b281ceee7b Increase maximum TSV packet size
Due to commit 45886edc40
faup1090: write _v on every line, bump TSV_VERSION
and maybe other changes the TSV packets are bigger and some users have
reported the following error:
piaware[9040]: faup1090(27427): fatsv: output too large (max 600, overran by 20)

Fix this error by increasing TSV_MAX_PACKET_SIZE to 800
2019-04-08 20:03:57 +02:00
Eric Tran 883399cee3 Bump version for piaware lat/lon fix 2019-03-29 19:05:26 -05:00
Eric Tran 0f2215c2ce
Merge pull request #36 from wiedehopf/lat_fix
Fix getting LAT/LON from piaware .env file
2019-03-29 16:54:09 -05:00
Matthias Wirth 91f3c3ce67 Fix getting LAT/LON from piaware .env file 2019-03-29 20:55:47 +01:00
Oliver Jowett a654c60d65 Release v3.7.0 2019-03-22 15:58:13 +00:00
Oliver Jowett 18c0758a67 Changelog, version bump 2019-03-21 22:18:19 +00:00
Oliver Jowett 77c8f9aafa Minimal skyview changes for nav_alt changes 2019-03-19 18:48:13 +00:00
Oliver Jowett f46640a5c2 Track and report autopilot FMS/MCP separately; also report autopilot altitude source. 2019-03-19 18:44:09 +00:00
Oliver Jowett 56aa2f7d1e Clarify some comments in v1 TSS 2019-03-19 18:23:49 +00:00
Oliver Jowett 45886edc40 faup1090: write _v on every line, bump TSV_VERSION 2019-03-19 18:10:38 +00:00
Oliver Jowett 14c458db8c Add an ENABLED line to /etc/default/dump1090-fa on upgrade if missing 2019-03-12 11:39:05 +00:00
Oliver Jowett 9136766b9c Set SyslogIdentifier on dump1090-fa 2019-03-11 18:21:31 +00:00
Oliver Jowett 719e004c7a Use %t in the service file 2019-03-11 18:16:00 +00:00
Oliver Jowett d66a05b019 Use a helper to start dump1090-fa so we can read ENABLED from the defaults file, like beast-splitter does 2019-03-11 17:01:16 +00:00
Oliver Jowett 0946d5165d changelog 2019-03-07 18:44:26 +00:00
Oliver Jowett 9dfc3e7aa6 Arrange to return a non-zero exit code if the SDR thread unexpectedly halts 2019-03-07 18:35:47 +00:00
Oliver Jowett 47e43778a6 Just use fprintf. 2019-03-07 18:19:23 +00:00
Oliver Jowett 28e7ccca8e If rtlsdr_read_async returns early, the device is probably hosed, give up;
rely on the caller of dump1090 to restart.
2019-03-07 18:15:47 +00:00
Oliver Jowett 10cfc13c3a More build deps 2019-03-04 15:43:45 +00:00
Oliver Jowett bd50f5d689 Version bump to 3.7.0~dev 2019-03-04 15:36:32 +00:00
Oliver Jowett 324491b0e6 Add fakeroot to try to make travis happy 2019-03-04 15:31:24 +00:00
Oliver Jowett 6abcebd0e4 Skyview: finish up init properly if there's no history to load 2019-03-04 15:17:16 +00:00
Oliver Jowett f04a71640a Skyview: try true_heading / mag_heading for icon rotation if track is missing 2019-03-04 15:13:51 +00:00
Oliver Jowett 671aac5f50 Merge branch 'master' into dev 2019-03-04 15:08:31 +00:00