Commit graph

16 commits

Author SHA1 Message Date
Oliver Jowett 39aeb7a48c Remove comm-b "consistency" bonuses, look at inconsistent data only.
Rescale penalties so badly inconsistent messages will tend to get
the same penalty in all formats, so the ambiguity check kicks in.

With this final change the HEADING_SPEED and TRACK_TURN message rates
are almost identical, which is what we'd expect to see if the
interrogator is asking for both at about the same rate.

Before:

    567 AMBIGUOUS
   7445 GICB_CAPS
  19173 EMPTY_RESPONSE
  75252 UNKNOWN
  76469 AIRCRAFT_IDENT
 127603 ACAS_RA
 212654 HEADING_SPEED
 223068 DATALINK_CAPS
 229807 TRACK_TURN
 269267 VERTICAL_INTENT
    466 "suspicious"

After:

   7445 GICB_CAPS
  17432 AMBIGUOUS
  19173 EMPTY_RESPONSE
  75252 UNKNOWN
  76469 AIRCRAFT_IDENT
 127603 ACAS_RA
 212718 HEADING_SPEED
 212878 TRACK_TURN
 223068 DATALINK_CAPS
 269267 VERTICAL_INTENT
    328 "suspicious"
2019-05-02 18:19:27 +08:00
Oliver Jowett 5eb0bd10ea Bail out on unlikely comm-b data values in more places.
Before:

    575 AMBIGUOUS
   7090 GICB_CAPS
  19173 EMPTY_RESPONSE
  71686 UNKNOWN
  76469 AIRCRAFT_IDENT
 127603 ACAS_RA
 212887 HEADING_SPEED
 223068 DATALINK_CAPS
 230008 TRACK_TURN
 272746 VERTICAL_INTENT

    861 "suspicious"

After:

    567 AMBIGUOUS
   7445 GICB_CAPS
  19173 EMPTY_RESPONSE
  75252 UNKNOWN
  76469 AIRCRAFT_IDENT
 127603 ACAS_RA
 212654 HEADING_SPEED
 223068 DATALINK_CAPS
 229807 TRACK_TURN
 269267 VERTICAL_INTENT

    466 "suspicious"
2019-05-02 18:06:17 +08:00
Oliver Jowett f968fea390 Just bail out of comm-b decoding early on really bad data, don't bother with a big negative score.
No change to test results.
2019-05-02 18:03:40 +08:00
Oliver Jowett d5741bf8c8 Require more fields to be populated in BDS5,0/BDS6,0 before we'll accept them at all.
Before:

   7090 GICB_CAPS
  10667 AMBIGUOUS
  19173 EMPTY_RESPONSE
  62527 UNKNOWN
  76469 AIRCRAFT_IDENT
 127603 ACAS_RA
 210286 HEADING_SPEED
 223068 DATALINK_CAPS
 232824 TRACK_TURN
 271598 VERTICAL_INTENT

   2517 "suspicious"

After:

    575 AMBIGUOUS
   7090 GICB_CAPS
  19173 EMPTY_RESPONSE
  71686 UNKNOWN
  76469 AIRCRAFT_IDENT
 127603 ACAS_RA
 212887 HEADING_SPEED
 223068 DATALINK_CAPS
 230008 TRACK_TURN
 272746 VERTICAL_INTENT

    861 "suspicious"
2019-05-02 17:58:03 +08:00
Oliver Jowett c9bea6a21c Store comm-b gs in gs.selected to help the decoder tests out.
Usually this is set in track.c, but the tests don't use that code path.

This somewhat increases the number of "suspicious" messages found.
2019-05-02 17:54:48 +08:00
Oliver Jowett 27f41c178f Allow comm-b aircraft-ident messages containing @, but don't actually use the callsign.
before:
  62905 UNKNOWN
  76091 AIRCRAFT_IDENT

after:
  62527 UNKNOWN
  76469 AIRCRAFT_IDENT
2019-05-02 17:51:46 +08:00
Oliver Jowett b8fb5e5fe5 If there is no single best-scoring comm-b format, mark the message as ambiguous.
This mostly affects TRACK_TURN messages on my test set. before:

 127603 ACAS_RA
  19173 EMPTY_RESPONSE
 210286 HEADING_SPEED
 223068 DATALINK_CAPS
 243445 TRACK_TURN
 271644 VERTICAL_INTENT
  62905 UNKNOWN
   7090 GICB_CAPS
  76091 AIRCRAFT_IDENT

  15973 "suspicious"

after:

  10667 AMBIGUOUS
 127603 ACAS_RA
  19173 EMPTY_RESPONSE
 210286 HEADING_SPEED
 223068 DATALINK_CAPS
 232824 TRACK_TURN
 271598 VERTICAL_INTENT
  62905 UNKNOWN
   7090 GICB_CAPS
  76091 AIRCRAFT_IDENT

   2258 "suspicious"
2019-05-02 17:44:37 +08:00
Oliver Jowett 1b5b0dfa03 Put ais_charset in its own file to make building commb tests a little easier 2019-05-02 17:24:26 +08:00
Oliver Jowett 161d2d8ded More WIP 2017-12-07 10:34:08 -06:00
Oliver Jowett 6986b3847f WIP on new faup1090 output, data aging, refactoring 2017-12-02 17:38:33 +00:00
Oliver Jowett a3cdd47d80 ADSBv2 uses bit 15 of BDS1,0 2017-06-19 11:27:14 -05:00
Oliver Jowett 2f53b57278 Fix typo in BDS6,0 scoring 2017-06-16 10:56:11 +01:00
Oliver Jowett 382554a250 Tweak tracking of AP modes, emit in json & faup1090 output 2017-06-16 10:39:01 +01:00
Oliver Jowett 1ec32903ba Rework heading/track to include HRD/TAH.
Clean up TIS-B flag output.
2017-06-15 21:07:53 +01:00
Oliver Jowett 27b0e9c40f Rename TARGET_* -> INTENT_ALT_*
Rearrange the intent tracking a bit.
2017-06-15 18:23:28 +01:00
Oliver Jowett 98d64483d6 WIP: More Comm-B & ADS-B decoding. 2017-06-15 18:07:40 +01:00