AFG/dump1090
3
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Merge pull request #33 from hhm0/socket_hang

Browse source 
Close network file descriptors when finished with them
This commit is contained in:
MalcolmRobb 2014-10-29 12:55:16 +00:00
parent d1ad4b91c6 3333fcd5bc
commit c142c1fe2e
1 changed files with 41 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

62
net_io.c
View file

@ -161,8 +161,15 @@ void modesFreeClient(struct client *c) {
} }
} }
// It's now safe to remove this client free(c);
close(c->fd); }
//
//=========================================================================
//
// Close the client connection and mark it as closed
//
void modesCloseClient(struct client *c) {
close(c->fd);
if (c->service == Modes.sbsos) { if (c->service == Modes.sbsos) {
if (Modes.stat_sbs_connections) Modes.stat_sbs_connections--; if (Modes.stat_sbs_connections) Modes.stat_sbs_connections--;
} else if (c->service == Modes.ros) { } else if (c->service == Modes.ros) {
@ -174,7 +181,7 @@ void modesFreeClient(struct client *c) {
if (Modes.debug & MODES_DEBUG_NET) if (Modes.debug & MODES_DEBUG_NET)
printf("Closing client %d\n", c->fd); printf("Closing client %d\n", c->fd);
free(c); c->fd = -1;
} }
// //
//========================================================================= //=========================================================================
@ -188,15 +195,19 @@ void modesSendAllClients(int service, void *msg, int len) {
// Read next before servicing client incase the service routine deletes the client! // Read next before servicing client incase the service routine deletes the client!
struct client *next = c->next; struct client *next = c->next;
if (c->service == service) { if (c->fd != -1) {
if (c->service == service) {
#ifndef _WIN32 #ifndef _WIN32
int nwritten = write(c->fd, msg, len); int nwritten = write(c->fd, msg, len);
#else #else
int nwritten = send(c->fd, msg, len, 0 ); int nwritten = send(c->fd, msg, len, 0 );
#endif #endif
if (nwritten != len) { if (nwritten != len) {
modesFreeClient(c); modesCloseClient(c);
}
} }
} else {
modesFreeClient(c);
} }
c = next; c = next;
} }
@ -714,11 +725,12 @@ int handleHTTPRequest(struct client *c, char *p) {
httpver = (strstr(p, "HTTP/1.1") != NULL) ? 11 : 10; httpver = (strstr(p, "HTTP/1.1") != NULL) ? 11 : 10;
if (httpver == 10) { if (httpver == 10) {
// HTTP 1.0 defaults to close, unless otherwise specified. // HTTP 1.0 defaults to close, unless otherwise specified.
keepalive = strstr(p, "Connection: keep-alive") != NULL; //keepalive = strstr(p, "Connection: keep-alive") != NULL;
} else if (httpver == 11) { } else if (httpver == 11) {
// HTTP 1.1 defaults to keep-alive, unless close is specified. // HTTP 1.1 defaults to keep-alive, unless close is specified.
keepalive = strstr(p, "Connection: close") == NULL; //keepalive = strstr(p, "Connection: close") == NULL;
} }
keepalive = 0;
// Identify he URL. // Identify he URL.
p = strchr(p,' '); p = strchr(p,' ');
@ -852,6 +864,10 @@ void modesReadFromClient(struct client *c, char *sep,
nread = recv(c->fd, c->buf+c->buflen, left, 0); nread = recv(c->fd, c->buf+c->buflen, left, 0);
if (nread < 0) {errno = WSAGetLastError();} if (nread < 0) {errno = WSAGetLastError();}
#endif #endif
if (nread == 0) {
modesCloseClient(c);
return;
}
// If we didn't get all the data we asked for, then return once we've processed what we did get. // If we didn't get all the data we asked for, then return once we've processed what we did get.
if (nread != left) { if (nread != left) {
@ -862,7 +878,7 @@ void modesReadFromClient(struct client *c, char *sep,
#else #else
if ( (nread < 0) && (errno != EWOULDBLOCK)) { // Error, or end of file if ( (nread < 0) && (errno != EWOULDBLOCK)) { // Error, or end of file
#endif #endif
modesFreeClient(c); modesCloseClient(c);
return; return;
} }
if (nread <= 0) { if (nread <= 0) {
@ -910,7 +926,7 @@ void modesReadFromClient(struct client *c, char *sep,
} }
// Have a 0x1a followed by 1, 2 or 3 - pass message less 0x1a to handler. // Have a 0x1a followed by 1, 2 or 3 - pass message less 0x1a to handler.
if (handler(c, s)) { if (handler(c, s)) {
modesFreeClient(c); modesCloseClient(c);
return; return;
} }
fullmsg = 1; fullmsg = 1;
@ -926,7 +942,7 @@ void modesReadFromClient(struct client *c, char *sep,
while ((e = strstr(s, sep)) != NULL) { // end of first message if found while ((e = strstr(s, sep)) != NULL) { // end of first message if found
*e = '\0'; // The handler expects null terminated strings *e = '\0'; // The handler expects null terminated strings
if (handler(c, s)) { // Pass message to handler. if (handler(c, s)) { // Pass message to handler.
modesFreeClient(c); // Handler returns 1 on error to signal we . modesCloseClient(c); // Handler returns 1 on error to signal we .
return; // should close the client connection return; // should close the client connection
} }
s = e + strlen(sep); // Move to start of next message s = e + strlen(sep); // Move to start of next message
@ -953,15 +969,19 @@ void modesReadFromClients(void) {
struct client *c = modesAcceptClients(); struct client *c = modesAcceptClients();
while (c) { while (c) {
// Read next before servicing client incase the service routine deletes the client! // Read next before servicing client incase the service routine deletes the client!
struct client *next = c->next; struct client *next = c->next;
if (c->service == Modes.ris) { if (c->fd >= 0) {
modesReadFromClient(c,"\n",decodeHexMessage); if (c->service == Modes.ris) {
} else if (c->service == Modes.bis) { modesReadFromClient(c,"\n",decodeHexMessage);
modesReadFromClient(c,"",decodeBinMessage); } else if (c->service == Modes.bis) {
} else if (c->service == Modes.https) { modesReadFromClient(c,"",decodeBinMessage);
modesReadFromClient(c,"\r\n\r\n",handleHTTPRequest); } else if (c->service == Modes.https) {
modesReadFromClient(c,"\r\n\r\n",handleHTTPRequest);
}
} else {
modesFreeClient(c);
} }
c = next; c = next;
} }