From 8a52108d773a3e98f11fbf3ee60714208edfcc40 Mon Sep 17 00:00:00 2001
From: Oliver Jowett <oliver@mutability.co.uk>
Date: Fri, 16 Jun 2017 10:39:57 +0100
Subject: [PATCH] Clean up js-side data capture, fix naming on ground track /
 speed.

---
 public_html/index.html     |  4 +--
 public_html/planeObject.js | 63 ++++++++++++--------------------------
 2 files changed, 22 insertions(+), 45 deletions(-)

diff --git a/public_html/index.html b/public_html/index.html
index e479197..6a99d14 100644
--- a/public_html/index.html
+++ b/public_html/index.html
@@ -103,7 +103,7 @@
 								<span id="selected_squawk"></span>
 							</div>
 							<div class="infoHeading infoRowFluid fourColumnSection3">
-								Speed:
+								Groundspeed:
 							</div>
 							<div class="infoData infoRowFluid fourColumnSection4">
 								<span id="selected_speed">n/a</span>
@@ -127,7 +127,7 @@
 					<div class="infoBlockSection lightGreyBackground">
 						<div>
 							<div class="infoHeading infoRowFluid fourColumnSection1">
-								Heading:
+								Ground track:
 							</div>
 							<div class="infoData infoRowFluid fourColumnSection2">
 								<span id="selected_track">n/a</span>
diff --git a/public_html/planeObject.js b/public_html/planeObject.js
index 1d6eace..684a3f0 100644
--- a/public_html/planeObject.js
+++ b/public_html/planeObject.js
@@ -425,54 +425,31 @@ PlaneObject.prototype.updateData = function(receiver_timestamp, data) {
 	this.messages	= data.messages;
         this.rssi       = data.rssi;
 	this.last_message_time = receiver_timestamp - data.seen;
+
+        // simple fields
+
+        var fields = ["altitude", "alt_geom", "gs", "ias", "tas", "track",
+                      "track_rate", "mag_heading", "true_heading", "mach",
+                      "roll", "intent_alt", "intent_heading",
+                      "alt_setting", "baro_rate", "geom_rate", "flight",
+                      "squawk", "category", "version"];
+
+        for (var i = 0; i < fields.length; ++i) {
+                if (fields[i] in data) {
+                        this[fields[i]] = data[fields[i]];
+                } else {
+                        this[fields[i]] = null;
+                }
+        }
+
+        // fields with more complex behaviour
         
-        if (typeof data.type !== "undefined")
+        if ('type' in data)
                 this.addrtype	= data.type;
         else
                 this.addrtype   = 'adsb_icao';
 
-        if (typeof data.altitude !== "undefined")
-                this.altitude = data.altitude;
-        if (typeof data.alt_geom !== "undefined")
-                this.alt_geom = data.alt_geom;
-        if (typeof data.gs !== "undefined")
-                this.gs = data.gs;
-        if (typeof data.ias !== "undefined")
-                this.ias = data.ias;
-        if (typeof data.tas !== "undefined")
-                this.tas = data.tas;
-        if (typeof data.track !== "undefined")
-                this.track = data.track;
-        if (typeof data.track_rate !== "undefined")
-                this.track_rate = data.track_rate;
-        if (typeof data.mag_heading !== "undefined")
-                this.mag_heading = data.mag_heading;
-        if (typeof data.true_heading !== "undefined")
-                this.true_heading = data.true_heading;
-        if (typeof data.mach !== "undefined")
-                this.mach = data.mach;
-        if (typeof data.roll !== "undefined")
-                this.roll = data.roll;
-        if (typeof data.intent_alt !== "undefined")
-                this.intent_alt = data.intent_alt;
-        if (typeof data.intent_heading !== "undefined")
-                this.intent_heading = data.intent_heading;
-        if (typeof data.alt_setting !== "undefined")
-                this.alt_setting = data.alt_setting;
-        if (typeof data.baro_rate !== "undefined")
-                this.baro_rate = data.baro_rate;
-        if (typeof data.geom_rate !== "undefined")
-                this.geom_rate = data.geom_rate;
-        if (typeof data.flight !== "undefined")
-		this.flight	= data.flight;
-        if (typeof data.squawk !== "undefined")
-		this.squawk	= data.squawk;
-        if (typeof data.category !== "undefined")
-                this.category	= data.category;
-        if (typeof data.version !== "undefined")
-                this.version = data.version;
-
-        if (typeof data.lat !== "undefined") {
+        if ('lat' in data && 'lon' in data) {
                 this.position   = [data.lon, data.lat];
                 this.last_position_time = receiver_timestamp - data.seen_pos;